fix: preserve pip diagnostics when dependency downloads fail - #930
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
github-actions
Bot
added
pr/external
stage/needs-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: Fixes #363.
Description of changes
Keep pip's original error output when a download ends with a no-matching-distribution message. Certificate verification errors preceding that final message are currently discarded, making a certificate problem look like a missing package. Preserve the existing exception type and keep direct
NoSuchPackageError(package_name)calls compatible.Prepared with OpenAI Codex assistance.
Description of how you validated changes
The SSL-diagnostic regression fails before the fix. All 129 Python packaging unit tests pass afterward. The broader unit suite reports 829 passed and three failures; the same three failures reproduce with the original production file (Windows command lookup and a Rust logger mock expectation). Black and diff checks pass. Ruff reports the same 16 existing test-file findings before and after; production file passes. No live SAM deployment, Docker build, or certificate configuration changes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.